feat: Enable CloudTrail log delivery bucket policy option #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikpaasonen
changed the title
|
Oh, I fixed the wrappers. |
antonbabenko
changed the title
antonbabenko
approved these changes
Jun 17, 2025
antonbabenko
merged commit 1a431dd
into
terraform-aws-modules:master
20 of 21 checks passed
|
Thanks @erikpaasonen ! |
antonbabenko
pushed a commit
that referenced
this pull request
Jun 17, 2025
## [4.11.0](v4.10.1...v4.11.0) (2025-06-17) ### Features * Enable CloudTrail log delivery bucket policy option ([#332](#332)) ([1a431dd](1a431dd))
|
This PR is included in version 4.11.0 🎉 |
3 tasks
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new module parameter in the manner of existing log delivery flags to conditionally inject CloudTrail logs delivery to the S3 bucket's policy.
Motivation and Context
Implements the suggested solution in #331.
Breaking Changes
N/A
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull requestI could use some assistance with resolving the wrapper finding from
pre-commitplease.Note:
masterdoes not build correctly due to duplicate SIDs in the combined policy doc:This PR includes making these unique.